-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Add more models for benchmark and polish codes #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
narendasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good outside of the changes to _compiler.py. Just want like a high level summary of what is changing there so I know what to look at, since its a bit hard to tell.
|
@narendasan Sorry for the confusion. The idea of modifying |
narendasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change on a warning then LGTM. You can push this branch with the fix to your fork and open a new PR and I can merge it.
Description
Add more models for benchmark and polish codes
Type of change
Checklist: