Skip to content

Conversation

@zewenli98
Copy link
Collaborator

Description

Add more models for benchmark and polish codes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Sep 9, 2025
@meta-cla meta-cla bot added the cla signed label Sep 9, 2025
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Sep 9, 2025
@github-actions github-actions bot requested a review from peri044 September 9, 2025 20:45
@zewenli98 zewenli98 requested a review from narendasan September 9, 2025 20:45
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good outside of the changes to _compiler.py. Just want like a high level summary of what is changing there so I know what to look at, since its a bit hard to tell.

@zewenli98
Copy link
Collaborator Author

@narendasan Sorry for the confusion. The idea of modifying _compiler.py is just to keep the function convert_exported_program_to_serialized_trt_engine() having the same behavior as compile(), except returning different outputs. This is because folks just added/modified codes to compile() but not to the other. In this PR, You can see the two functions are almost same now. For future maintainability, do you think we need to modulize them?

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on a warning then LGTM. You can push this branch with the fix to your fork and open a new PR and I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants