Skip to content

Breaking Change: Remove the deprecated int8 calibrator related #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Remove all the int8 calibrator, int8 implicit quantization and dynamic range related.
All the quantization should be explicit.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Aug 7, 2025
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API component: runtime component: fx component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 7, 2025
@github-actions github-actions bot requested a review from zewenli98 August 7, 2025 06:47
@lanluo-nvidia lanluo-nvidia added the ciflow/binaries/all Build for all Python Versions label Aug 7, 2025
Copy link

pytorch-bot bot commented Aug 7, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review August 7, 2025 15:13
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, if the fx changes still work I would leave those since Meta might still be using them.

Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a minor comment

Comment on lines 8 to 10
from torch_tensorrt.fx.converters.converter_utils import (
mark_as_int8_layer,
set_layer_name,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reasons for partially replacing import lib?

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking good, only thing is if we are switching to dynamo.types.TRTTensor we should just go to trt.ITensor and be closer to removing that types file. Dont think I need to review again after those changes

Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can directly use trt.ITensor instead of alias, but it doesn't matter. that's fine for now

@zewenli98
Copy link
Collaborator

An error pops up.

E   ImportError: cannot import name 'Frameworks' from 'torch_tensorrt.dynamo.conversion.converter_utils'

you can import from torch_tensorrt.dynamo.utils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Build for all Python Versions cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests fx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants