Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add strong type support:
ITensor dynamic_range is deprecated since TRT10.1
we should not use dynamic_range to implicit the INT8 quantization.
We should only do explicit int8 quantization via modelopt.
ref:
https://docs.nvidia.com/deeplearning/tensorrt/latest/_static/python-api/infer/Graph/LayerBase.html#tensorrt.ITensor
In this PR, I only removed the implicit int8 quantization for the dynamo path, torchscript path is not being removed.
torch.ops.aten.atan2.default
if input tensor shape is torch.half, output shape should be torch.half, but we specifically added a cast to torch.float32
Please let me know if it is for some historical reasons
https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/conversion/impl/elementwise/ops.py#L255-L258
torch.embedding_bag
we have specidifically added a cast to torch.float32, please let me know if it is for some historical reasons?
https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/conversion/impl/embedding.py#L368
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: