Skip to content

add strong typing fix #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add strong typing fix #3749

wants to merge 2 commits into from

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Add strong type support:

  1. ITensor dynamic_range is deprecated since TRT10.1
    we should not use dynamic_range to implicit the INT8 quantization.
    We should only do explicit int8 quantization via modelopt.
    ref:
    https://docs.nvidia.com/deeplearning/tensorrt/latest/_static/python-api/infer/Graph/LayerBase.html#tensorrt.ITensor
    In this PR, I only removed the implicit int8 quantization for the dynamo path, torchscript path is not being removed.

  2. torch.ops.aten.atan2.default
    if input tensor shape is torch.half, output shape should be torch.half, but we specifically added a cast to torch.float32
    Please let me know if it is for some historical reasons
    https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/conversion/impl/elementwise/ops.py#L255-L258

  3. torch.embedding_bag
    we have specidifically added a cast to torch.float32, please let me know if it is for some historical reasons?
    https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/conversion/impl/embedding.py#L368

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Aug 5, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 5, 2025
@github-actions github-actions bot requested a review from peri044 August 5, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant