Skip to content

fix: typing issue in Python 3.9 and earlier #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: typing issue in Python 3.9 and earlier #3431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py/torch_tensorrt/dynamo/conversion/_ConverterRegistry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def __contains__(self, key: Target | Node) -> bool:
def get_all_converters_with_target(
self, key: Target, return_registry_info: bool = False
) -> Tuple[
List[Any], Dict[str, int] | None
Union[List[Any], Dict[str, int], None]
]: # TODO: Narrow to ConverterImplSignature this when we can remove FX converters
"""Get all converters across all registries for the target

Expand Down
2 changes: 1 addition & 1 deletion py/torch_tensorrt/dynamo/runtime/_MutableTorchTensorRTModule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def forward(a, b, c=0, d=0):

self.refit_state.set_state(RefitFlag.NEEDS_RECOMPILE)

def _get_total_dynamic_shapes(self) -> dict[str, Any] | None:
def _get_total_dynamic_shapes(self) -> Union[dict[str, Any], None]:
if not self.arg_dynamic_shapes and not self.kwarg_dynamic_shapes:
return None
total_dynamic_shape = {}
Expand Down
Loading