Skip to content

cherry-pick: Add release flag for nightly build tag (#2821) #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024
Merged

cherry-pick: Add release flag for nightly build tag (#2821) #2835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c281cf5
ci: Add release flag for nightly build tag (#2821)
gs-olive May 14, 2024
1a07128
Resolve numpy not found issue
gs-olive Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packaging/pre_build_script_windows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ python -m pip install tensorrt==10.0.1 --extra-index-url https://pypi.nvidia.com
choco install bazelisk -y

cat toolchains/ci_workspaces/WORKSPACE.win.release.tmpl | envsubst > WORKSPACE

echo "RELEASE=1" >> ${GITHUB_ENV}
Copy link
Collaborator

@peri044 peri044 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this related to channel=release in the yml files ?

Copy link
Contributor Author

@gs-olive gs-olive May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion here: #2806 (comment), this flag seems to get the package naming correct on the Torch upload index. I do not think it directly relates to the channel from the .yml files.

3 changes: 2 additions & 1 deletion tests/py/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ tensorrt==10.0.1
timm>=1.0.3
transformers==4.39.3
parameterized>=0.2.0
expecttest==0.1.6
expecttest==0.1.6
numpy==1.24.1