Skip to content

fix: refactor layer norm converter with INormalization Layer #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: refactor layer norm converter with INormalization Layer #2755

merged 2 commits into from
Apr 26, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Refactored layer norm converter with TRT INormalization Layer

Fixes #2730

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 added the component: converters Issues re: Specific op converters label Apr 16, 2024
@zewenli98 zewenli98 self-assigned this Apr 16, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 16, 2024
narendasan
narendasan approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase

@zewenli98 zewenli98 force-pushed the refactor_layer_norm_dynamo_converter branch from 4e47a38 to fbed329 Compare April 26, 2024 22:52
@zewenli98 zewenli98 merged commit 1a4ffe4 into main Apr 26, 2024
@zewenli98 zewenli98 deleted the refactor_layer_norm_dynamo_converter branch April 26, 2024 23:43
peri044 pushed a commit that referenced this pull request Apr 29, 2024
@zewenli98 @peri044
fix: refactor layer norm converter with INormalization Layer (#2755)
744abeb
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
fix: refactor layer norm converter with INormalization Layer (#2755)
d98bf22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

@apbose apbose Awaiting requested review from apbose

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❓ [Question] Running LayerNorm in fp16
3 participants
@zewenli98 @narendasan @facebook-github-bot