Skip to content

Support new FX Legacy Registry in opset coverage tool #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Support new FX Legacy Registry in opset coverage tool #2366

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9aa67
Support FX Legacy registry name; use constants for registry names
laikhtewari Oct 6, 2023
7627cbb
error if unknown registry name
laikhtewari Oct 6, 2023
6cd890f
Python style
laikhtewari Oct 6, 2023
74777cb
fix whitespace
laikhtewari Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions py/torch_tensorrt/dynamo/tools/opset_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ class OpsetCoverage:
Path(os.path.dirname(torchgen.__file__)) / "packaged/ATen/native/tags.yaml"
)

DYNAMO_REGISTRY_NAME = "Dynamo ATen Converters Registry"
FX_REGISTRY_NAME = "FX ATen Converters Registry"
FX_LEGACY_REGISTRY_NAME = "FX Legacy ATen Converters Registry"


def get_aten_ops() -> List[Tuple[str, str]]:
parsed_yaml = parse_native_yaml(NATIVE_FUNCTION_YAML_PATH, TAGS_YAML_PATH)
Expand Down Expand Up @@ -140,13 +144,25 @@ def opset_coverage(
_, registry_data = c_registry.get_all_converters_with_target(
target, return_registry_info=True
)

if registry_data is not None:
if registry_data["Dynamo ATen Converters Registry"] >= 1:
if (
DYNAMO_REGISTRY_NAME in registry_data
and registry_data[DYNAMO_REGISTRY_NAME] >= 1
):
status = SupportStatus.CONVERTED
support_count += 1
elif registry_data["FX ATen Converters Registry"] >= 1:
elif (
FX_REGISTRY_NAME in registry_data
and registry_data[FX_REGISTRY_NAME] >= 1
) or (
FX_LEGACY_REGISTRY_NAME in registry_data
and registry_data[FX_LEGACY_REGISTRY_NAME] >= 1
):
status = SupportStatus.LEGACY_CONVERTED
legacy_count += 1
else:
raise Exception(f"Op belongs to unknown registry: {registry_data}")

support_status[target_str] = {
"schema": f"{target_str.split('.')[0]}.{opset_schemas[target_str]}",
Expand Down