Skip to content

[FX] disable 2 of conv3d and type_as tests #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2022
Merged

[FX] disable 2 of conv3d and type_as tests #1224

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3c6ebe
Update test_convolution.py
Aug 2, 2022
859d823
Update test_type_as.py
Aug 2, 2022
512da3b
Update config.yml
Aug 2, 2022
4d771d2
Update test_convolution.py
Aug 5, 2022
063b793
c++ format fix
Aug 5, 2022
85b52c0
manual fix format for one file
Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ parameters:
# Nightly platform config
torch-nightly-build:
type: string
default: "1.13.0.dev20220715+cu113"
default: "1.13.0.dev20220731+cu113"
torch-nightly-build-index:
type: string
default: "https://download.pytorch.org/whl/nightly/cu113"
Expand Down
3 changes: 2 additions & 1 deletion py/torch_tensorrt/fx/test/converters/acc_op/test_convolution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ def forward(self, x):
("tuple_parameters", 1, (1, 1), (1, 1)),
param("non_zero_padding", 1, padding=1),
param("dilation", 1, dilation=2),
param("groups", 1, groups=3),
# TODO TRT 8.4.1 will trigger issue with this test. T127981773
# param("groups", 1, groups=3),
]
)
def test_conv2d(
Expand Down
4 changes: 3 additions & 1 deletion py/torch_tensorrt/fx/test/converters/acc_op/test_type_as.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import torch
import unittest
import torch_tensorrt.fx.tracer.acc_tracer.acc_ops as acc_ops
from torch.testing._internal.common_utils import run_tests
from torch_tensorrt.fx.tools.common_fx2trt import AccTestCase, InputTensorSpec
Expand Down Expand Up @@ -102,7 +103,8 @@ def forward(self, input):
expected_ops={acc_ops.to_dtype},
precision=LowerPrecision.FP16,
)


@unittest.skip("Does not pass in TRT 8.4.1 T127981773")
def test_type_tensor_with_dynamic_shape_four_dimensions(self):
class Type_as(torch.nn.Module):
def forward(self, input):
Expand Down