Set several default initial args to None for convenience
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
force-pushed
the
default_none
branch
2 times, most recently
from
305d25b to
cfc9f4e
Compare
Member
|
LGTM 👍, just remove the 'may need to make |
frozencemetery
force-pushed
the
default_none
branch
from
cfc9f4e to
dec88d0
Compare
The goal here is to change all calls to methods of the form `add_cred(None)` to `add_cred()` for convenience and clarity. It has been verified that `acquire_cred_from()` can take nulls. This closes pythongssapi#29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be all occurrences in the low-level api, and so this should close #29.
More defaults can be set, but: