Skip to content

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra
Copy link
Member Author

Let's not merge this until python/peps#3440 is merged.

@alicederyn
Copy link
Contributor

alicederyn commented Nov 28, 2023

PEP-705 has dropped both readonly and other_keys flags; only the typing.ReadOnly annotation needs to be added now.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions (mostly optional), but overall this looks good!

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 0b0166d into python:main Nov 29, 2023
@JelleZijlstra JelleZijlstra deleted the pep705 branch November 29, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants