Add missing imports from typing #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! How did you discover this? |
|
Thanks for quick merge! Here is mypy PR python/mypy#2863 I will rebase it after next "sync typeshed". The problem is that these errors become runtime errors if you turn them from type comments to variable annotations, I discovered this some time ago. The fix is very simple, see mypy PR. |
gvanrossum
pushed a commit
to python/mypy
that referenced
this pull request
Feb 14, 2017
Fix #999 This is a straightforward fix: List, Set, and Dict are treated as aliases to their builtins counterparts, therefore they are ignored by remove_imported_names_from_symtable, I fix this by also removing the alias names. The fix also revealed few places in mypy where imports were missing, and one bug in fastparse.py. Those have been fixed. The fix also includes a typeshed sync at python/typeshed#933.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dict,List, andSetwere not imported fromtyping. Mypy didn't notice this because of python/mypy#999Here I fix this by adding missing imports and will make a PR to mypy soon.