Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 29, 2022

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 29, 2022

I don't really want to spend my time reviewing a PR like this for a module that's long-deprecated and about to be removed :(

Same goes for #9035

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

Yeah, I can totally understand, sometimes I feel this too!
(I even have a backlog of things to review) 😆

But, since typeshed still supports >=3.7, people are and will still use these modules.
This is why I even bothered creating this PR.

Maybe someone else will review it! If you feel like it, closing these two PRs is always an option.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 30, 2022

Yeah, to be clear — I've no objections to other maintainers reviewing and merging this if they want to :)

@JelleZijlstra JelleZijlstra merged commit b24a22c into python:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants