bz2: fix bytes parameters #9015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 28, 2022
| def flush(self) -> bytes: ... | ||
|
|
||
| @final | ||
| class BZ2Decompressor: | ||
| def decompress(self, data: bytes, max_length: int = ...) -> bytes: ... | ||
| def decompress(self, data: ReadableBuffer, max_length: int = ...) -> bytes: ... |
There was a problem hiding this comment.
I was a bit concerned here, as decompress uses while data: and I'm not sure if all buffers support that, but it turns out that data is overwritten with BZ2Decompressor.unused_data at the end of the first loop iteration, which appears to be bytes. So if push comes to shove, an empty bytes string is pushed into BZ2Decompressor.decompress() once (which has no effect), and then - since unused_data is now an empty bytes, it will exit the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.