Skip to content

regex: add support for RegexFlag class #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

rrthomas
Copy link
Contributor

No description provided.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood
Copy link
Member

The failing stub-uploader test is nothing to worry about -- the same test is failing on the stub-uploader master branch:

(Cc. @hauntsaninja)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator

srittau commented Oct 11, 2022

The test failure seems unrelated, probably caused by typeshed-internal/stub_uploader#61.

@srittau srittau merged commit 708996d into python:master Oct 11, 2022
@rrthomas
Copy link
Contributor Author

Thanks for merging this PR, @srittau! As I understand it, the corresponding type-stubs package (here, regex-types) should be automatically released after the change, but it has not been. Is some other change (like a version bump) needed?

@srittau
Copy link
Collaborator

srittau commented Oct 14, 2022

Indeed. Actually, this CI run claims that it was uploaded, but it wasn't: https://github.com/typeshed-internal/stub_uploader/actions/runs/3228142124/jobs/5283851894

I'm investigating.

@srittau
Copy link
Collaborator

srittau commented Oct 14, 2022

@JelleZijlstra
Copy link
Member

I manually triggered a new version of regex and it somehow succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants