Add reportMissingParameterType to pyrightconfig.stricter.json
#8770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| replace_paths=..., | ||
| implies=..., | ||
| graph: Incomplete | None = ..., | ||
| user_hook_dirs: Iterable[StrOrBytesPath] = ..., |
There was a problem hiding this comment.
Bytes paths don't work: PyInstaller.depend.analysis.PyiModuleGraph("x", [b"y"]) throws a TypeError.
There was a problem hiding this comment.
TypeError: Can't mix strings and bytes in path components
This is probably the case in other parts of the stubs as well 😓 I'll go back through other StrOrBytesPath and make a PR to fix them when they're explicitly used with strings.
| graph: Incomplete | None = ..., | ||
| user_hook_dirs: Iterable[StrOrBytesPath] = ..., | ||
| excludes: Iterable[str] = ..., | ||
| path: Iterable[str] | None = ..., |
There was a problem hiding this comment.
These and further args are keyword-only, since they're forwarded through **kwargs.
There was a problem hiding this comment.
Didn't know keyword-only arguments were a thing. Thanks!
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Sep 21, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed in #8702 (comment)
Completes the types in keyboard and PyInstaller (which I've both added recently) so that this option can be turned on.