Add type signature for a WSGI Application to wsgiref #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is something core to Python and is useful when typing web applications, but doesn't actually exist in the stdlib anywhere. I put this in wsgiref, but I am open to suggestions as for a better place.
ambv
commented
Jan 13, 2017
| @@ -26,7 +26,7 @@ WSGIApplication = Callable[ | |||
| Dict[str, str], | |||
| Union[ | |||
| Callable[[str, List[Tuple[str, str]]], Callable[[Union[bytes, str]], None]], | |||
| Callable[[str, List[Tuple[str, str]], _exc_info], Callable[[Union[bytes, str]], None]] | |||
| Callable[[str, List[Tuple[str, str]], _exc_info], Callable[[Union[bytes, str]], None]], | |||
| ] | |||
There was a problem hiding this comment.
There's another one right here ;-)
|
Sorry for breaking the CI. Will send a PR with a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #725 but includes original commits by @rowillia.
@gvanrossum, this includes all your comments from review on the other pull request. It had to be a new pull request because the original was not done against current master. Once you rebase, all commits are different, it's no longer the same PR. This is why you couldn't simply edit on GitHub.