-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Overhaul socket
stubs on Windows and MacOS
#8106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a pretty heroic PR. I'd want to double check there aren't any Linux regressions before merging.
Can confirm stubtest also looks good on my Mac laptop (in case there were OS version or hardware specific things we're missing). For what it's worth, I have socket.MSG_NOSIGNAL
on 3.8 and above — curious what you were seeing.
I was using GH Actions on my fork to run stubtest on macos, and it seemed like it varied from one stubtest run to the next as to whether it existed at runtime. |
Here's a failing Ubuntu stubtest run from yesterday on my fork, before I added the allowlist back for linux, if that's helpful: https://github.com/AlexWaygood/typeshed/runs/6955971392?check_suite_focus=true I'd rather not make any linux-specific changes in this PR, if at all possible, since (1) I don't have a linux machine, and (2) I know very little about linux and the various linux operating systems. |
Confirmed that we didn't accidentally regress availability of any constants on Linux on Python 3.9 (same set of "is not present in stub" errors) |
Awesome, thanks for checking! |
Helps with #8101.
This PR reduces the
(_)socket
allowlists for win32 and darwin to only a handful of missing constants/functions.