-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add new or missing socket constants on linux #8101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm in favour of adding these, and of getting some more coverage from stubtest. I can take a look on Windows to see what needs adding. Missing |
Stubtest is enabled for all the socket constants on Windows and macOS these days, but we still have two very broad allowlist entries on linux:
|
Match the documentation more closely Fixes some of python#8101
I removed the two broad linux allowlist entries as part of #13044 . This issue can probably be closed now. |
Fantastic, thank you! |
We currently silence many errors from socket constants in stubtest, because the availability of some constants cannot be expressed in the type system (and probably also because historically we weren't always the best at specifying all platform differences exactly). However, this means we don't notice new additions.
On macOS, with python3.10:
I can add PRs for these / check this for Linux. Filing this issue mainly as a reminder for myself to do so. Would be good if someone wants to take another look at Windows.
The text was updated successfully, but these errors were encountered: