Skip to content

jack: Fix MidiPort properties #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2022
Merged

jack: Fix MidiPort properties #7730

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
819f39d
jack: Fix MidiPort properties
JelleZijlstra Apr 28, 2022
9595619
Update stubs/JACK-Client/jack/__init__.pyi
JelleZijlstra Apr 28, 2022
45c524d
Add missing import
AlexWaygood Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions stubs/JACK-Client/jack/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from _typeshed import Self
from collections.abc import Callable, Generator, Iterable, Iterator, Sequence
from typing import Any, overload
from typing_extensions import TypeAlias
from typing_extensions import Literal, TypeAlias

_NDArray: TypeAlias = Any # FIXME: no typings for numpy arrays

Expand Down Expand Up @@ -180,8 +180,10 @@ class Port:
def request_monitor(self, onoff: bool) -> None: ...

class MidiPort(Port):
is_audio: bool = ...
is_midi: bool = ...
@property
def is_audio(self) -> Literal[False]: ...
@property
def is_midi(self) -> Literal[True]: ...

class OwnPort(Port):
@property
Expand Down