Remove Python 2 support from simplejson #7704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
approved these changes
Apr 27, 2022
| from typing_extensions import TypeAlias | ||
|
|
||
| from simplejson.decoder import JSONDecoder as JSONDecoder | ||
| from simplejson.encoder import JSONEncoder as JSONEncoder, JSONEncoderForHTML as JSONEncoderForHTML | ||
| from simplejson.raw_json import RawJSON as RawJSON | ||
| from simplejson.scanner import JSONDecodeError as JSONDecodeError | ||
|
|
||
| _LoadsString: TypeAlias = Text | bytes | bytearray | ||
| _LoadsString: TypeAlias = str | bytes | bytearray |
There was a problem hiding this comment.
If I understand correctly, the explicit | bytearray isn't necessary.
There was a problem hiding this comment.
PEP 688 would make it necessary again.
There was a problem hiding this comment.
Or rather, we could possibly switch to types.Buffer (needs investigating).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7367