Add @final to several stdlib classes that cannot be subclassed at runtime

[AlexWaygood]

No description provided.

[hauntsaninja]

It looks like this might be a subset of the ones found in python/mypy#12091 ? Or am I missing something

[AlexWaygood]

It looks like this might be a subset of the ones found in python/mypy#12091 ? Or am I missing something

Nope, you're exactly right -- I'm working on a patch for stubtest so I'm using a tweaked version of stubtest on the master branch :)

So yes, these are all "known" about -- but they're still worth fixing!

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[hauntsaninja]

Definitely worth fixing, I was just curious about the subset aspect, e.g. http.HTTPStatus, xxlimited.Xxo are missing. So was wondering if there were false positives or something

[AlexWaygood]

Definitely worth fixing, I was just curious about the subset aspect, e.g. http.HTTPStatus, xxlimited.Xxo are missing. So was wondering if there were false positives or something

• http.HTTPStatus didn't end up in the final diff produced by stubtest: error if a class should be decorated with @final mypy#12091, because it's an Enum (so implicitly @final; stubtest raising an error would be a false positive there).
• xxlimited isn't available on Windows, so stubtest won't pick it up on my machine :)

[hauntsaninja]

Okay, sg, I can add the unix ones!