Skip to content

bisect: insort_*, unlike bisect_*, expects x to match type of elements of a #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2022
Merged

bisect: insort_*, unlike bisect_*, expects x to match type of elements of a #7102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97cd883
bisect: insort_*, unlike bisect_*, expects x to match type of element…
Kentzo Feb 2, 2022
bc55f2a
fix missing import of SupportsRichComparison
Kentzo Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions stdlib/_bisect.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
from _typeshed import SupportsRichComparisonT
from _typeshed import SupportsRichComparison, SupportsRichComparisonT
from typing import Callable, MutableSequence, Sequence, TypeVar, overload

_T = TypeVar("_T")
Expand Down Expand Up @@ -27,27 +27,21 @@ if sys.version_info >= (3, 10):
*,
key: Callable[[_T], SupportsRichComparisonT] = ...,
) -> int: ...
@overload
def insort_left(a: MutableSequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> None: ...
@overload
def insort_left(
a: MutableSequence[_T],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_T should probably be SupportsRichComparisonT here and elsewhere, but that's probably out of scope for this PR.

x: SupportsRichComparisonT,
x: _T,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparisonT] = ...,
key: Callable[[_T], SupportsRichComparison] | None = ...,
) -> None: ...
@overload
def insort_right(a: MutableSequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> None: ...
@overload
def insort_right(
a: MutableSequence[_T],
x: SupportsRichComparisonT,
x: _T,
lo: int = ...,
hi: int | None = ...,
*,
key: Callable[[_T], SupportsRichComparisonT] = ...,
key: Callable[[_T], SupportsRichComparison] | None = ...,
) -> None: ...

else:
Expand Down