bisect: insort_*, unlike bisect_*, expects x to match type of elements of a #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The only failure does not seem to relate to the change. |
If you close and reopen your PR, it should trigger a fresh CI run. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Feb 2, 2022
| @@ -27,27 +27,21 @@ if sys.version_info >= (3, 10): | |||
| *, | |||
| key: Callable[[_T], SupportsRichComparisonT] = ..., | |||
| ) -> int: ... | |||
| @overload | |||
| def insort_left(a: MutableSequence[_T], x: _T, lo: int = ..., hi: int | None = ..., *, key: None = ...) -> None: ... | |||
| @overload | |||
| def insort_left( | |||
| a: MutableSequence[_T], | |||
There was a problem hiding this comment.
_T should probably be SupportsRichComparisonT here and elsewhere, but that's probably out of scope for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/python/cpython/pull/20556/files#r432997024 for reference.