Skip to content

Use types-urllib3 for requests #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions stubs/requests/@tests/stubtest_allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,63 +28,6 @@ requests.models.RequestField.__init__
requests.models.RequestField.from_tuples
requests.options
requests.packages.VendorAlias
requests.packages.urllib3.HTTPConnectionPool.__init__
requests.packages.urllib3.HTTPConnectionPool.urlopen
requests.packages.urllib3.HTTPResponse.__init__
requests.packages.urllib3.HTTPSConnectionPool.__init__
requests.packages.urllib3.NullHandler
requests.packages.urllib3.PoolManager.connection_from_host
requests.packages.urllib3.PoolManager.connection_from_url
requests.packages.urllib3.PoolManager.urlopen
requests.packages.urllib3.ProxyManager.__init__
requests.packages.urllib3.ProxyManager.connection_from_host
requests.packages.urllib3.ProxyManager.urlopen
requests.packages.urllib3.Retry.is_forced_retry
requests.packages.urllib3.Retry.sleep
requests.packages.urllib3._collections.HTTPHeaderDict.from_httplib
requests.packages.urllib3._collections.HTTPHeaderDict.getlist
requests.packages.urllib3._collections.RLock
requests.packages.urllib3.connection.HTTPConnection.request
requests.packages.urllib3.connection.HTTPSConnection.__init__
requests.packages.urllib3.connection.VerifiedHTTPSConnection.__init__
requests.packages.urllib3.connection.VerifiedHTTPSConnection.set_cert
requests.packages.urllib3.connectionpool.ConnectionError
requests.packages.urllib3.connectionpool.HTTPConnection.request
requests.packages.urllib3.connectionpool.HTTPConnectionPool.__init__
requests.packages.urllib3.connectionpool.HTTPConnectionPool.urlopen
requests.packages.urllib3.connectionpool.HTTPResponse.__init__
requests.packages.urllib3.connectionpool.HTTPSConnection.__init__
requests.packages.urllib3.connectionpool.HTTPSConnectionPool.__init__
requests.packages.urllib3.connectionpool.ProxyError.__init__
requests.packages.urllib3.connectionpool.RequestMethods.request_encode_url
requests.packages.urllib3.connectionpool.Retry.is_forced_retry
requests.packages.urllib3.connectionpool.Retry.sleep
requests.packages.urllib3.connectionpool.VerifiedHTTPSConnection.__init__
requests.packages.urllib3.connectionpool.VerifiedHTTPSConnection.set_cert
requests.packages.urllib3.exceptions.ProxyError.__init__
requests.packages.urllib3.fields.RequestField.__init__
requests.packages.urllib3.fields.RequestField.from_tuples
requests.packages.urllib3.filepost.RequestField.__init__
requests.packages.urllib3.filepost.RequestField.from_tuples
requests.packages.urllib3.poolmanager.PoolManager.connection_from_host
requests.packages.urllib3.poolmanager.PoolManager.connection_from_url
requests.packages.urllib3.poolmanager.PoolManager.urlopen
requests.packages.urllib3.poolmanager.ProxyManager.__init__
requests.packages.urllib3.poolmanager.ProxyManager.connection_from_host
requests.packages.urllib3.poolmanager.ProxyManager.urlopen
requests.packages.urllib3.request.RequestMethods.request_encode_url
requests.packages.urllib3.response.HTTPHeaderDict.from_httplib
requests.packages.urllib3.response.HTTPHeaderDict.getlist
requests.packages.urllib3.response.HTTPResponse.__init__
requests.packages.urllib3.response.PY3
requests.packages.urllib3.util.Retry.is_forced_retry
requests.packages.urllib3.util.Retry.sleep
requests.packages.urllib3.util.connection.poll
requests.packages.urllib3.util.connection.select
requests.packages.urllib3.util.retry.Retry.is_forced_retry
requests.packages.urllib3.util.retry.Retry.sleep
requests.packages.urllib3.util.ssl_.create_default_context
requests.packages.urllib3.util.ssl_.ssl_wrap_socket
requests.patch
requests.post
requests.put
Expand Down
1 change: 1 addition & 0 deletions stubs/requests/METADATA.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
version = "2.27.*"
requires = ["types-urllib3<1.27"] # keep in sync with requests's setup.py
python2 = true
5 changes: 3 additions & 2 deletions stubs/requests/requests/adapters.pyi
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from typing import Any, Container, Mapping, Text

from urllib3 import exceptions as urllib3_exceptions, poolmanager, response
from urllib3.util import retry

from . import cookies, exceptions, models, structures, utils
from .packages.urllib3 import exceptions as urllib3_exceptions, poolmanager, response
from .packages.urllib3.util import retry

PreparedRequest = models.PreparedRequest
Response = models.Response
Expand Down
2 changes: 1 addition & 1 deletion stubs/requests/requests/exceptions.pyi
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any

from .packages.urllib3.exceptions import HTTPError as BaseHTTPError
from urllib3.exceptions import HTTPError as BaseHTTPError

class RequestException(IOError):
response: Any
Expand Down
3 changes: 2 additions & 1 deletion stubs/requests/requests/models.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import datetime
from json import JSONDecoder
from typing import Any, Callable, Iterator, Text, Type, TypeVar

from urllib3 import exceptions as urllib3_exceptions, fields, filepost, util

from . import auth, cookies, exceptions, hooks, status_codes, structures, utils
from .cookies import RequestsCookieJar
from .packages.urllib3 import exceptions as urllib3_exceptions, fields, filepost, util

_VT = TypeVar("_VT")

Expand Down
2 changes: 2 additions & 0 deletions stubs/requests/requests/packages/__init__.pyi
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# requests also imports urllib3 as requests.packages.urllib3, the stubs don't reflect that.

class VendorAlias:
def __init__(self, package_names) -> None: ...
def find_module(self, fullname, path=...): ...
Expand Down
26 changes: 0 additions & 26 deletions stubs/requests/requests/packages/urllib3/__init__.pyi

This file was deleted.

51 changes: 0 additions & 51 deletions stubs/requests/requests/packages/urllib3/_collections.pyi

This file was deleted.

64 changes: 0 additions & 64 deletions stubs/requests/requests/packages/urllib3/connection.pyi

This file was deleted.

121 changes: 0 additions & 121 deletions stubs/requests/requests/packages/urllib3/connectionpool.pyi

This file was deleted.

Empty file.
Loading