Skip to content

Use types-urllib3 for requests #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2022
Merged

Use types-urllib3 for requests #6859

merged 6 commits into from
Jan 8, 2022

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Jan 8, 2022

Mark urllib3 as supporting Python 2

Akuli
Akuli reviewed Jan 8, 2022
View reviewed changes
@srittau
Copy link
Collaborator Author

srittau commented Jan 8, 2022

#6860 for a check_consistent fix.

Akuli
Akuli reviewed Jan 8, 2022
View reviewed changes
Akuli
Akuli approved these changes Jan 8, 2022
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and import changes look correct.

@Akuli Akuli merged commit f8501d3 into python:master Jan 8, 2022
@srittau srittau deleted the requests-urllib branch January 8, 2022 14:36
@jpy-git
Copy link
Contributor

jpy-git commented Jan 8, 2022

I opened #6794 a couple days back to address #6054 where someone wanted requests/packages/urllib3/exceptions.pyi updated. Given that we've removed that file in this PR, will close #6794 👍

@jpy-git jpy-git mentioned this pull request Jan 8, 2022
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request Jan 11, 2022
Closed
@AlexWaygood AlexWaygood mentioned this pull request Jun 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srittau @jpy-git @Akuli