Add openpyxl stubs #6801
Merged
Add openpyxl stubs #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm out of ideas. |
|
We'll probably need to change stubtest to try-except more exception types in this case. Unfortunately that may mean we have to wait for the next mypy release. |
JelleZijlstra
added a commit
to python/mypy
that referenced
this pull request
Jan 9, 2022
srittau
added
the
status: deferred
|
I'm marking this as deferred for now. |
|
There's a list of distributions to skip running stubtest on; you could add to that to unblock this PR. Edit: looks like this was changed to a TOML flag in #6687 |
JelleZijlstra
added a commit
to python/mypy
that referenced
this pull request
Jan 12, 2022
|
The toml flag was removed in the meantime as well as we fixed all remaining problems. We could reintroduce it, but we can also just wait for the next mypy release. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Merged
|
#7351 will allow us to merge despite stubtest. |
srittau
removed
the
status: deferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stubgen + import cleanup + mypy fixes + black + isort