Remove FieldDescriptor fallback for protobuf extension methods #5754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was there for compatibility to older versions of mypy-protobuf. With modular typeshed, this sort of straddling code will no longer be necessary! Thanks @ilevkivskyi
nipunn1313
force-pushed
the
extension_dict
branch
from
e1c6e0a to
a7665eb
Compare
nipunn1313
commented
Jul 10, 2021
| # Dummy fallback overloads with FieldDescriptor are for backward compatibility with | ||
| # mypy-protobuf <= 1.23. We can drop them a few months after 1.24 releases. | ||
| @overload | ||
| def __init__(self, extended_message: _ContainerMessageT): ... |
There was a problem hiding this comment.
this made stubtest happy
There was a problem hiding this comment.
There was a problem hiding this comment.
This should not be needed. Can you please re-add -> None so we can have a look at the failure in CI?
There was a problem hiding this comment.
ah this was absolutely a mistake on my part. I had
- Accidentally deleted the init
- Saw a CI failure because it was missing
- Readded it manually, but poorly.
Undoing my error!
srittau
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was there for compatibility to older versions of mypy-protobuf.
With modular typeshed, this sort of straddling code will no longer
be necessary! Thanks @ilevkivskyi