Skip to content

Conversation

JelleZijlstra
Copy link
Member

To help contributors keep track of which features can be used in stubs.

To help contributors keep track of which features can be used in stubs.
@JelleZijlstra JelleZijlstra requested a review from srittau May 17, 2021 02:04
CONTRIBUTING.md Outdated
- [PEP 613](https://www.python.org/dev/peps/pep-0613/) (TypeAlias):
see [#4913](https://github.com/python/typeshed/issues/4913)

Features for which support was recently added include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to be the canonical listing of features that can be used in typeshed, perhaps just say "Features that can be used in typeshed include" as to not have to explain how recently "recently" is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I didn't want to go through all the old features, but there aren't actually that many. I'll just add a full list of the relevant PEPs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't mean to make you do that work, the word "include" is probably enough leeway to only list a subset.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I had to do most of the work already for the typing_extensions list I added below

@srittau srittau merged commit 02be4b5 into master May 17, 2021
@srittau srittau deleted the supported-features branch May 17, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants