Updating subprocess.pyi to support python 3.5 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added DEVNULL which was added in 3.3
Contributor
Author
|
This is in response to #437 |
stdlib/3/subprocess.pyi
Outdated
| from typing import Sequence, Any, Mapping, Callable, Tuple, IO, Optional, Union, List | ||
|
|
||
|
|
||
| if sys.version_info >= 3.5: |
stdlib/3/subprocess.pyi
Outdated
| def __init__(self, args: Union[List, str], | ||
| returncode: int, | ||
| stdout: Union[str, bytes], | ||
| stderr: Union[str, bytes]): ... |
Forgot that __init__ should return None and also forgot "self" on a method. Like a dummy.
Contributor
Author
|
@matthiaskramm When should this be available for use in mypy? I don't know how this repository is released and such. |
Contributor
|
I'm told they update their typeshed submodule once a week or so. So pretty soon I guess? |
Member
|
Yeah, watch for a commit to the mypy repo saying "Sync typeshed."
…--Guido (mobile)
|
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added DEVNULL which was added in 3.3