Add msilib and _msi to stubtest whitelist #3939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@hauntsaninja I can't request you as reviewer, so I'll do it here. |
| zipfile.ZipExtFile.readline | ||
| zlib.compressobj | ||
|
|
||
| # Modules that do not exist on Linux systems and cannot be checked by our CI process. |
Collaborator
There was a problem hiding this comment.
nit: I'd move this below the "Whitelist entries that cannot or should not be fixed" header.
Additionally, if we're looking to try to minimise "unused whitelist entry" errors if someone attempts to run stubtest_test.py on Windows locally, we might want to modify the list as follows, using the method described in python/mypy#8502 (comment) to allow these entries to go unused:
(_msi)?
(_winapi)?
(msilib(\.[a-z]+)?)?
(msvcrt)?
(winsound)?
Make win modules optional
hauntsaninja
approved these changes
Apr 23, 2020
grievejia
pushed a commit
to grievejia/typeshed
that referenced
this pull request
Apr 24, 2020
* Add msilib and _msi to stubtest whitelist * Group Windows-only modules * Move win modules to bottom Make win modules optional
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
* Add msilib and _msi to stubtest whitelist * Group Windows-only modules * Move win modules to bottom Make win modules optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build failures on master.