typeshed: run stubtest in CI #3727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an example of what errors in Travis would look like, you can see https://travis-ci.org/hauntsaninja/typeshed/jobs/646198477 |
This organises the section a little better. Previously some tests were unmentioned; it read as if mypy_test and pytype_test were the only tests. The section is now organised by test, making it easy to keep track of the requirements and details of each. This also makes it easier to add documentation for stubtest. Also mention turning on Travis CI on your fork, since that is very useful.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation along the lines of what I proposed in #754. One difference from that is I moved errors that occur in all of py35-py38 into a shared whitelist. This felt like a good balance between reducing redundancy, preserving the ability to easily detect unused whitelist entries and implementation simplicity. Another difference is that I incorporated the discussion from #3693.
This is a draft until python/mypy#8325 gets merged (cc @JelleZijlstra ), at which point I can switch things to use mypy instead of my fork, as noted in the last commit.
Errors have come down substantially: overall by about half, py38-only by about 70%, as measured by the decrease since I first posted in #754.
Also happy to split out the README changes if that's better.