Improve werkzeug exceptions slightly #3178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srittau
commented
Aug 9, 2019
srittau
commented
- Use Text for HTTPException.description
- Add Unauthorized.www_authenticate
- Remove wrong get_headers() overrides
* Use Text for HTTPException.description * Add Unauthorized.www_authenticate * Remove wrong get_headers() overrides
srittau
commented
Aug 9, 2019
| self, | ||
| description: Optional[Text] = ..., | ||
| response: Optional[Response] = ..., | ||
| www_authenticate: Union[None, Tuple[object], List[object], object] = ..., |
There was a problem hiding this comment.
This union could technically be reduced to just object, but I like the fact that it expresses the different cases handled by the implementation better.
There was a problem hiding this comment.
Tuple[object, ...] surely?
JelleZijlstra
requested changes
Aug 9, 2019
| self, | ||
| description: Optional[Text] = ..., | ||
| response: Optional[Response] = ..., | ||
| www_authenticate: Union[None, Tuple[object], List[object], object] = ..., |
There was a problem hiding this comment.
Tuple[object, ...] surely?
JelleZijlstra
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.