Skip to content

make logging.basicConfig parameters Optional[...] #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

make logging.basicConfig parameters Optional[...] #3170

merged 1 commit into from
Aug 7, 2019

Conversation

V3RGANz
Copy link
Contributor

@V3RGANz V3RGANz commented Aug 7, 2019

to avoid type errors like Argument “filename” to “basicConfig” has incompatible type “Optional[str]“; expected “Union[str, _PathLike[str]]”
all parameters accessed by kwargs.pop(param, None) made Optional

@V3RGANz V3RGANz changed the title make basicConfig parameters Optional[...] make logging.basicConfig parameters Optional[...] Aug 7, 2019
srittau
srittau approved these changes Aug 7, 2019
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 0dea39c into python:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V3RGANz @srittau