Skip to content

Added Optional encoding for TextIOWrapper #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

Added Optional encoding for TextIOWrapper #3125

merged 1 commit into from
Jul 17, 2019

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Jul 16, 2019 •
edited
Loading

fixed #3124

bluetech
bluetech approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems like it was always optional. The python2 stub already gets it right.

srittau
srittau approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 8e89faa into python:master Jul 17, 2019
sfermigier pushed a commit to sfermigier/typeshed that referenced this pull request Jul 18, 2019
@WillAyd @sfermigier
Added Optional (python#3125)
e56147d 
Fixes python#3124
@WillAyd WillAyd deleted the fix-textio branch August 25, 2019 16:15
@WillAyd WillAyd mentioned this pull request Aug 25, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

+1 more reviewer

@bluetech bluetech bluetech approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextIOWrapper.encoding missing Optional Argument
3 participants
@WillAyd @srittau @bluetech