Skip to content

Revert "Define functools.partial as overloaded function instead of its own class" #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

JelleZijlstra
Copy link
Member

Reverts #2878

Caused problems in many real-world codebases. Proper support for partial will have to come from a plugin instead.

I've seen the following problems reported:

  • Keyword arguments to partial() functions no longer work
  • isinstance() checks on functools.partial no longer work
  • Access to .func and other attributes no longer works

@JelleZijlstra JelleZijlstra requested review from srittau and JukkaL June 20, 2019 14:53
@JelleZijlstra JelleZijlstra merged commit ada0570 into master Jun 21, 2019
@JelleZijlstra JelleZijlstra deleted the revert-2878-overloaded_partial branch June 21, 2019 03:40
JelleZijlstra added a commit that referenced this pull request Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants