Support new ast features and node types introduced in Python 3.8 #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to adjust the return type of ast.parse() from Module to AST, which is more truthful anyways.
srittau
reviewed
Mar 11, 2019
stdlib/3/_ast.pyi
Outdated
| col_offset: int # TODO: Not all nodes have this | ||
| if sys.version_info >= (3, 8): | ||
| end_lineno: int | ||
| end_col_offset: int # TODO: Not all nodes have this |
There was a problem hiding this comment.
Shouldn't these two attributes be Optional?
stdlib/3/_ast.pyi
Outdated
|
|
||
| class FunctionType(mod): | ||
| argtypes = ... # type: typing.List[expr] | ||
| returns = ... # type: expr |
There was a problem hiding this comment.
I'd prefer variable annotation syntax for new code (even if existing code in the file still uses comment syntax). Applies to classes below as well.
stdlib/3/_ast.pyi
Outdated
| @@ -253,6 +270,14 @@ class Bytes(expr): | |||
| class NameConstant(expr): | |||
| value = ... # type: Any | |||
|
|
|||
| if sys.version_info >= (3, 8): | |||
| class Constant(expr): | |||
| value = ... # type: expr | |||
There was a problem hiding this comment.
I guess this a an expr, because constants can be assigned an arbitrary expression? I mainly ask, because the old constant classes all had more concrete attribute types like 'str', 'float' (or Any in the case of NameConstant).
|
Thanks for the very thorough code review. Note that I added |
srittau
approved these changes
Mar 12, 2019
This was referenced Mar 12, 2019
gvanrossum
added a commit
to python/mypy
that referenced
this pull request
Mar 15, 2019
To test with Python 3.8, this requires python/cpython#12295. The typeshed changes were in python/typeshed#2859 (and synced in #6540).
rchen152
added a commit
to google/pytype
that referenced
this pull request
Mar 21, 2019
python/typeshed#2859 changed the return type. Module is a subclass of AST, so it's still correct, just less precise. Based on the PR description, this change was intentional. PiperOrigin-RevId: 239423111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
TypeIgnore,FunctionType,ConstantandNamedExprASTattributesend_lineno,end_col_offset, andtype_commentModule.type_ignoresStr.kind(that's new in 3.7 actually)ast.parse():type_comments=<bool>andfeature_version=<int>I had to adjust the return type of
ast.parse()from Module toAST, which is more truthful anyways.