allow for unicode entity dicts in saxutils #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchen152
reviewed
Jul 24, 2018
stdlib/2and3/xml/sax/saxutils.pyi
Outdated
| def escape(data: AnyStr, entities: Mapping[str, str] = ...) -> AnyStr: ... | ||
| def unescape(data: AnyStr, entities: Mapping[str, str] = ...) -> AnyStr: ... | ||
| def quoteattr(data: AnyStr, entities: Mapping[str, str] = ...) -> AnyStr: ... | ||
| def escape(data: AnyStr, entities: Mapping[Union[str, Text], Union[str, Text]] = ...) -> AnyStr: ... |
There was a problem hiding this comment.
The return type isn't quite right anymore. On my machine, I see (in Python 2):
>>> from xml.sax import saxutils
>>> saxutils.escape('a', {'a': u'd'})
u'd'
>>> saxutils.escape('a', {u'a': 'd'})
u'd'
So the return type doesn't necessary match the type of data.
There was a problem hiding this comment.
good point! so i suppose most generally all types should be Union[str, Text]] even though that loses us a bit of information in the cases where AnyStr was correcy
There was a problem hiding this comment.
I think you can just used Text; Union[str, Text] is redundant in Python 3, and in Python 2, Text should be used for something that can be either bytes or unicode (https://github.com/python/typeshed/blob/master/CONTRIBUTING.md).
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml.sax.saxutils accepts unicode keys and values in its entitles dict