Skip to content

Add FileHandler properties #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/2and3/logging/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,10 @@ class StreamHandler(Handler):


class FileHandler(Handler):
baseFilename = ... # type: str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer PEP 526-style annotations (e.g. baseFilename: str).

mode = ... # type: str
encoding = ... # type: Optional[str]
delay = ... # type: bool
def __init__(self, filename: str, mode: str = ...,
encoding: Optional[str] = ..., delay: bool = ...) -> None: ...

Expand Down