Add FileHandler properties #1834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Completely untested right now - haven't checked how to test, yet. Will do when I get the chance, or someone else can do so for me.) |
Resolves python#1833
ExplodingCabbage
force-pushed
the
fix-filehandler
branch
from
412419b to
68ced67
Compare
|
You should write some code that exercises the various forms of the API, and run it to make sure it runs error-free, and then type-check it. We prefer not to have such test code in the typeshed repo, however, because this would essentially duplicate the actual runtime tests for the library. And yet, type-checking those runtime tests often will fail for other reasons. See #754 for more discussion. |
| @@ -373,6 +373,10 @@ class StreamHandler(Handler): | |||
|
|
|||
|
|
|||
| class FileHandler(Handler): | |||
| baseFilename = ... # type: str | |||
There was a problem hiding this comment.
Prefer PEP 526-style annotations (e.g. baseFilename: str).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1833