stub for imaplib (2and3)

[mcepl]

Fixes #295

[mcepl]

OK, I give up. Could I ask for help, please, how to fix these remaining validation errors? What does Invalid type "typing.AnyStr" mean? I am lost.

[gvanrossum]

You can't use AnyStr the way you tried. If you replace it with Union[bytes, Text] it should have the effect you want. (AnyStr is really a type variable, so only applicable in generic class and function definitions.)

[mcepl]

Thanks for the hint. So, what do you think?

[gvanrossum]

I think you amended your commit. Please don't do that in the future.

…

On Oct 25, 2017 12:38 PM, "Matěj Cepl" ***@***.***> wrote: Thanks for the hint. So, what do you think? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1685 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMq9vYU7zMENaXFw7p0XluwMjYkFOks5sv45CgaJpZM4QE0Lv> .

[mcepl]

Of course, I did. Sorry, I live in other worlds where it is the right thing to do. Did I miss it in the Contributing.md? Actually, even you are pointing to this blogpost. You should probably clarify it somewhere, if you don't want clueless newbies to screw up your workflow. Sorry again.

[gvanrossum]

The recommendation to squash commits is for core devs who are merging PRs -- we should use the Squash-and-merge button. (As I will do shortly.) But PR authors should not squash.

[mcepl]

we should use the Squash-and-merge button. (As I will do shortly.)

OK, then I really don't understand. So, in the end you want to have just one commit per topic? Why then insist on messy squashed commit messages instead of the hand-crafted ones? I don't see any other difference.

[JelleZijlstra]

I believe squashing commits tends to mess up the attribution of previous inline review comments.

[mcepl]

OK, that's true. Not completely persuaded, but that makes at least some sense.

[gvanrossum]

Please stop arguing and just do as we ask. We've thought about this process. The point of not squashing commits is the review workflow, not the final commit (I always just clean up the commit message, and that's what our core devs instructions say). When you amend your commit and git push -f, GitHub doesn't send any notification, and doesn't have a way to tell me what changed since I last saw your PR. When you add a new commit it's clear what changed and the review is simpler.

[mcepl]

I am sorry, I was not trying to argue. Anyway, shutting up.