Skip to content

Fix callback parameter type in ssl.SSLContext.set_psk_server_callback #12932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix callback parameter type in ssl.SSLContext.set_psk_server_callback #12932

merged 1 commit into from
Oct 31, 2024

Conversation

brianschubert
Copy link
Contributor

@brianschubert brianschubert commented Oct 31, 2024 •
edited
Loading

Fixes #12931

For reference (docs):

The parameter callback is a callable object with the signature: def callback(identity: str | None) -> bytes.

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit d262beb into python:main Oct 31, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in ssl.set_psk_server_callback callback type signature
2 participants
@brianschubert @JelleZijlstra