Skip to content

Remove unneeded Iterator base class from asyncio.Future #12827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Remove unneeded Iterator base class from asyncio.Future #12827

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7620bd7
remove unneeded Awaitable base class from asyncio.Future
tungol Oct 16, 2024
b7e0ac9
and what if we keep awaitable but remove iterable?
tungol Oct 16, 2024
8c5ef51
make asyncio.Future covariant
tungol Oct 16, 2024
2c698b9
missed some
tungol Oct 16, 2024
bd94181
use Awaitable again
tungol Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/_asyncio.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys
from asyncio.events import AbstractEventLoop
from collections.abc import Awaitable, Callable, Coroutine, Generator, Iterable
from collections.abc import Awaitable, Callable, Coroutine, Generator
from contextvars import Context
from types import FrameType
from typing import Any, Literal, TextIO, TypeVar
Expand All @@ -13,7 +13,7 @@ _T = TypeVar("_T")
_T_co = TypeVar("_T_co", covariant=True)
_TaskYieldType: TypeAlias = Future[object] | None

class Future(Awaitable[_T], Iterable[_T]):
class Future(Awaitable[_T]):
_state: str
@property
def _exception(self) -> BaseException | None: ...
Expand Down
Loading