Skip to content

Correct _waiters type #11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2024
Merged

Correct _waiters type #11315

merged 1 commit into from
Jan 25, 2024

Conversation

Olegt0rr
Copy link
Contributor

Closes #11314

@github-actions GitHub Actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

anyio (https://github.com/agronholm/anyio)
+ src/anyio/_backends/_asyncio.py:1654: error: Unused "type: ignore" comment  [unused-ignore]

@Olegt0rr
Copy link
Contributor Author 

src/anyio/_backends/_asyncio.py:1654

https://github.com/agronholm/anyio/blob/1e60219d95bb6a3c1ddf0618634f8ee3eb566037/src/anyio/_backends/_asyncio.py#L1652-L1655

srittau
srittau approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit b4f60ac into python:main Jan 25, 2024
@Olegt0rr Olegt0rr deleted the correct-waiters-type branch January 26, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add _waiters type hints to asyncio.locks
2 participants
@Olegt0rr @srittau