Skip to content

Review Depth #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srittau opened this issue Nov 7, 2019 · 0 comments · Fixed by #4132
Closed

Review Depth #3448

srittau opened this issue Nov 7, 2019 · 0 comments · Fixed by #4132
Labels
project: policy Organization of the typeshed project

Comments

@srittau
Copy link
Collaborator

srittau commented Nov 7, 2019

I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording):

  • Auto-generated stubs: just do a brief scan for red flags, ignore possible improvements to keep contribution bar low.
  • Large hand-crafted PRs like my recent 3.8 PRs or the cryptography PR: while maintainer's are free to delve into it as deeply as they wish, mostly look for red flags, general issues, and do spot checks.
  • Smaller hand-crafted PRs: Do a thorough review.
@srittau srittau added the project: policy Organization of the typeshed project label Nov 7, 2019
srittau added a commit to srittau/typeshed that referenced this issue May 28, 2020
srittau added a commit that referenced this issue May 28, 2020
vishalkuo pushed a commit to vishalkuo/typeshed that referenced this issue Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: policy Organization of the typeshed project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant