Skip to content

Commit f58838b

Browse files
srittauVishal Kuo
authored and
Vishal Kuo
committed
Add review guidlines (python#4132)
Closes: python#3448
1 parent 33cab8d commit f58838b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,3 +373,13 @@ Core developers should follow these rules when processing pull requests:
373373
* Make sure commit messages to master are meaningful. For example, remove irrelevant
374374
intermediate commit messages.
375375
* If stubs for a new library are submitted, notify the library's maintainers.
376+
377+
When reviewing PRs, follow these guidelines:
378+
379+
* Typing is hard. Try to be helpful and explain issues with the PR,
380+
especially to new contributors.
381+
* When reviewing auto-generated stubs, just scan for red flags and obvious
382+
errors. Leave possible manual improvements for separate PRs.
383+
* When reviewing large, hand-crafted PRs, you only need to look for red flags
384+
and general issues, and do a few spot checks.
385+
* Review smaller, hand-crafted PRs thoroughly.

0 commit comments

Comments
 (0)