Stub for flask

[gvanrossum]

I could make one. Will work with @mitsuhiko to vet it.

[mykytaliubchych]

Is there any progress for this issue? Any help is needed?

[zoidyzoidzoid]

Additional offer to help.

[zoidyzoidzoid]

Should I start working on a PR maybe, and mitsuhiko or @pallets folk can take a look at it?

[gvanrossum]

We would be happy to accept a PR as long as the current flaks maintainers
are okay with it. Usually asking in their tracker and posting a link to a
positive response works well.

--Guido (mobile)

[rowillia]

Flask folks gave permission here - pallets/flask#2012

[gvanrossum]

Great! Get cracking!

[zoidyzoidzoid]

I've started working on it, and will happily accept PRs or any input: https://github.com/zoidbergwill/typeshed

Is there any documentation on tips on creating new stubs?

I've used stubgen, and am working on each file one by one now.

[gvanrossum]

Hm, I think the best way to learn how to create stubs ATM is probably to read a bunch of existing stubs. Please do understand that stubgen doesn't infer argument types except if there's a default, so you should add those manually. Also, there's no way to test that the stubs you create match the real flask library -- the way to assess that is typically to add annotations to a mid-size app using flask and to verify that the app both runs correctly and type-checks cleanly.

[zoidyzoidzoid]

Awesome, thanks. Browsing all the existing stubs in this repo have been how I've been figuring it out so far.

Thanks, will try that out. I have some Flask apps with some annotation coverage which I'll improve and then test it on.

[rowillia]

@zoidbergwill I've got a PR open that adds stubs to werkzeug - #530

[zoidyzoidzoid]

Thanks @rowillia Should I wait and then reuse some of your new types you're adding?