Add Windows release options for JIT builds #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
reviewed
May 2, 2025
Member
Author
|
Thanks for the suggestions, it's quite a bit cleaner now. |
Member
|
Okay, running a test build here (from a copy of this branch, not directly): https://dev.azure.com/Python/cpython/_build/results?buildId=161312&view=results FYI @ambv, we'll have a new version-specific option to select when running a release. |
Member
|
Test build was a success, so let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to test this, or even if this is the right approach, so I'd appreciate @zooba's eyes on this. Hopefully I'm on the right track, though.
I went ahead and "future-proofed" this by adding additional options for enabling the JIT by default (not desired until 3.15 at the earliest), and also building it on free-threaded builds (not possible until 3.15 at the earliest). These options can be dropped though, if they add too much noise.