Skip to content

Conversation

@englam
Copy link
Contributor

@englam englam commented Jul 16, 2023

20230716

@englam englam closed this Jul 18, 2023
@englam englam reopened this Jul 18, 2023
@englam
Copy link
Contributor Author

englam commented Jul 18, 2023

20230718 Reopen PR

Copy link
Collaborator

@cschan1828 cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulate you on your first commit! It is a significant milestone!

Noticed that some areas that can be improved with a little extra attention. Please have a look and improve the remaining parts to ensure the high quality of our shared work.

@cschan1828
Copy link
Collaborator

Additionally, I suggest you resolve the conflicts so that the CI checks can be enabled.

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多餘的 empty line

@mattwang44
Copy link
Collaborator

@englam
想請問你會繼續修這隻 PR 嗎?

@englam
Copy link
Contributor Author

englam commented Nov 7, 2023 via email

@mattwang44 mattwang44 changed the base branch from 3.11 to 3.12 November 9, 2023 13:17
@mattwang44 mattwang44 enabled auto-merge (squash) November 9, 2023 13:19
@mattwang44 mattwang44 disabled auto-merge November 9, 2023 15:12
@mattwang44 mattwang44 merged commit 3a6e035 into python:3.12 Nov 9, 2023
isabellechiu pushed a commit to isabellechiu/python-docs-zh-tw that referenced this pull request Dec 5, 2023
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants