Skip to content

Skip cache-busting for old Sphinx #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2023
Merged

Skip cache-busting for old Sphinx #113

merged 1 commit into from
Mar 11, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 11, 2023

Fix for #108 (comment).

Skip cache busting for Sphinx 3 and older.

@hugovk hugovk mentioned this pull request Mar 11, 2023
Merged
m-aciek
m-aciek approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally with Python 3.10 (Sphinx 3.4.3) and Python 3.7 (Sphinx 2.3.1), building and looking fine. Thank you!

@pradyunsg pradyunsg merged commit a6e262e into python:main Mar 11, 2023
@hugovk hugovk deleted the skip-cache-busting-for-old-sphinx branch March 11, 2023 17:40
This was referenced Mar 13, 2023
Merged
Closed
Merged
Merged
@joshhacksthings joshhacksthings mentioned this pull request Mar 16, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@m-aciek m-aciek m-aciek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @m-aciek @pradyunsg