Skip to content

Add mdp back into the default group #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add mdp back into the default group #219

merged 1 commit into from
Jul 5, 2022

Conversation

brandtbucher
Copy link
Member

When the mdp benchmark was added over 5 years ago, it was disabled by default because it took too long to run (reportedly 7-8 seconds).

However, this situation has improved somewhat (I time about 3 seconds on recent Python versions), and we're currently trying to move towards including more long-running benchmarks in the default suite.

It's a good benchmark, so let's enable it again.

@brandtbucher brandtbucher self-assigned this Jun 22, 2022
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an official reviewer here, but +1 from me. This seems aligned with recent discussions about types of benchmarks.

@ericsnowcurrently ericsnowcurrently merged commit ac914ac into python:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants